search

dodgingpixels / Optic

Public issue tracking for Optic - Photo Gallery [Android App]
15 stars 1 forks source link

Bottom sheet is white in all themes #20

Closed jahirfiquitiva closed 6 years ago

jahirfiquitiva commented 6 years ago

I think it would be nice if it matched the current theme

jahirfiquitiva commented 6 years ago

The same applies to overflow menu

staber commented 6 years ago

bottom sheet was intended this way because a dark sheet would clash with the black image background. Overflow is part of the theme and is not really intended to change dynamically.

jahirfiquitiva commented 6 years ago

I think both things should react to the theme. Also, both should use the card/dialog color for respective theme, so they wouldn't ever clash with the black background since they will never be black.

jahirfiquitiva commented 6 years ago

In addition to bottom sheet and overflow menu, dialogs are also light in other themes. As I mentioned already, I think all these should be affected by the current theme