search

dodingdaga / DalamudPlugins

GNU Affero General Public License v3.0
4 stars 4 forks source link

Latest update breaks Dalamud UI window sizes and other plugins. #16

Closed SirVG closed 1 month ago

SirVG commented 1 month ago

The latest update has now caused all of the Dalamud UI windows to blow up to an astronomical size that can't be shrunk down, plus has broken several other UI elements like QOL Bar.

I had to disable Puppetmaster to be able to fix everything else.

caitlyn-gg commented 1 month ago

@dodingdaga The offending commit is here.

You're pushing ImGuiStyleVar.WindowMinSize in a constructor and leaving it on the stack, causing any windows that are rendered afterward to be affected: https://github.com/dodingdaga/DalamudPluginsSources/blob/87418a29129cbffc85d64a68daa270fc8e8a045f/PuppetMaster/PluginUI.cs#L21

dodingdaga commented 1 month ago

should be ok now. sorry for the oversight!

dodingdaga commented 1 month ago

@dodingdaga The offending commit is here.

You're pushing ImGuiStyleVar.WindowMinSize in a constructor and leaving it on the stack, causing any windows that are rendered afterward to be affected: https://github.com/dodingdaga/DalamudPluginsSources/blob/87418a29129cbffc85d64a68daa270fc8e8a045f/PuppetMaster/PluginUI.cs#L21

THANK YOU SO MUCH~~~