search

dodo / node-slug

slugifies even utf-8 chars!
MIT License
1.07k stars 94 forks source link

conform with RFC 3986 #18

Closed LinusU closed 10 years ago

LinusU commented 10 years ago

This pull requests makes sure that slug only outputs correct url's that conforms to RFC 3986. This is an agreed upon standard of what characters are allowed in an url, and I think that this is something that we should adhere to.

To quote section 2.3 of RFC 3986:

Characters that are allowed in a URI but do not have a reserved purpose are called unreserved. These include uppercase and lowercase letters, decimal digits, hyphen, period, underscore, and tilde.

LinusU commented 10 years ago

This would also fix #16

niftylettuce commented 10 years ago

@LinusU @dodo can this be merged please?

durango commented 10 years ago

@dodo I need this as well please

ReedD commented 10 years ago

:+1: I agree

LinusU commented 10 years ago

Thanks!