dodo / node-slug

slugifies even utf-8 chars!
MIT License
1.07k stars 94 forks source link

Arabic characters #39

Closed Philmod closed 9 years ago

Philmod commented 9 years ago

Hey guys,

It doesn't work for some language:

> var t = "تحية الاسلام مدخل لدعوة غير المسلمين من الوافدين";
> slug(t);
''

Thanks, Philmod

dodo commented 9 years ago

Would you mind creating a pull request, where those chars get replaced by ASCII characters? Keep in mind that node-slug is not capable of transliteration which is discussed in #8.

Philmod commented 9 years ago

Yeah, I ended using that library.

montaro commented 8 years ago

I believe the Arabic letters are URL friendly, you just need not to omit them https://github.com/dodo/node-slug/issues/60