search

dodo / node-slug

slugifies even utf-8 chars!
MIT License
1.08k stars 92 forks source link

Docs out of sync #49

Open ghost opened 8 years ago

ghost commented 8 years ago

The docs on Github and npm are out of sync.

The npm docs (still?) tell you to set the "lowercase" options property to true in order to convert the slug to lower case, even though it's actually "lower" in the code, which is confusing.

danawoodman commented 8 years ago

This is no longer accurate and probably should be closed

ggarnier commented 8 years ago

Npm docs are still outdated

gscoon commented 8 years ago

Yes, NPM docs need to be updated.

Nateowami commented 8 years ago

Just spent a good while debugging and writing an issue about how lowercase: false had no effect. The NPM docs say both lowercase and lower, but the GitHub docs all say lower, which is the correct one.

aguyinmontreal commented 6 years ago

still an issue in 2018