search

dodo / node-slug

slugifies even utf-8 chars!
MIT License
1.07k stars 94 forks source link

PR: Fix issue #82 #91

Open vvanmol opened 6 years ago

vvanmol commented 6 years ago

This PR includes a possible fix for Issue #82.

Please accept the merge if you agree, otherwise let me know how would you see this fixed.

Regards

silvae86 commented 6 years ago

Any news on this?

pkyeck commented 6 years ago

If this is a fix for the security problem, it would be great to have this merged ... and a new version published to npm

vvanmol commented 6 years ago

I never got any answer to the PR...

gcphost commented 6 years ago

Almost 2 months later bump.

https://nodesecurity.io/advisories/537

This package is looking a bit stale.

woodyrew commented 6 years ago

@dodo Any chance of this being merged?

gcphost commented 6 years ago

@woodyrew
Slugify is still active. https://www.npmjs.com/package/slugify

hawkeye64 commented 6 years ago

Still waiting... :(

Ilshidur commented 6 years ago

Last commit/publish was 3 years ago and the main maintainer does not seem to be very active on GitHub currently :confused: I'm afraid some people have to pick alternatives like https://www.npmjs.com/package/slugify or https://www.npmjs.com/package/mollusc (active fork of this package) until this gets fixed.

woodyrew commented 6 years ago

Ironically, node-slug seems like it's owner: dead like a @dodo

StoneCypher commented 6 years ago

@dodo , please merge or nominate a maintainer

Trott commented 6 years ago

0.9.2 has been published with this issue fixed. https://www.npmjs.com/package/slug/v/0.9.2

@vvanmol Can you close this?

woodyrew commented 6 years ago

@Trott The changes haven't been pushed to this repo. Version is still 0.9.1 in package.json

vvanmol commented 6 years ago

Hi @Trott As mentioned by @woodyrew the new release is not part of this repository, I don't see my PR merged here... Did you take ownership of the repository somewhere else ?

Trott commented 6 years ago

@Trott The changes haven't been pushed to this repo. Version is still 0.9.1 in package.json

@woodyrew That's because I don't have write access to this repo. I do have access to publish the module on npm though, so I did the update in my own fork and published that to npm as 0.9.2. @dodo seems to be unreachable, but if they ever pop up again, I'm more than happy to turn anything and everything back over to them (or not--whatever they want). But until then... that's the situation.

I have a question in to a GitHub employee about whether GitHub has a process for this kind of situation that would allow me to get write access to this repo.