search

dodo / node-unicodetable

unicode lookup table
MIT License
42 stars 34 forks source link

Added missing proxy fields #22

Open nwinkler opened 8 years ago

nwinkler commented 8 years ago

When using http.get() to request a file through a proxy, the following were missing from the previous implementation:

These additions are based on http://stackoverflow.com/a/6781592/1228454 and work for our company proxy (MS NTLM Proxy).

The previous implementation always silently failed, it simply exited the process right after the fetching ... message.

euphocat commented 8 years ago

Worked for me too :+1:

nalbion commented 8 years ago

@dodo this would then resolve many issues on dependant projects: dodo/node-slug#58 keystonejs/generator-keystone#129

the symptom I'm seeing is Error: Cannot find module 'unicode/category/So'.

...The proxy server sends back a page saying "Sorry, I don't know how to get to that URL without a protocol" and this library tries to parse the error page as if it was UnicodeData.txt, so you end up with undefined.js and font-family: Tahoma, Roya, sans-serif.js in the category directory.

nimser commented 7 years ago

Does this needs any more work before merging?

dylanjha commented 7 years ago

This would also fix an issue I'm seeing on Circle CI:

😄

nicooprat commented 7 years ago

Hi there, any news on this? This issue is pretty annoying... :)

SamuelBolduc commented 7 years ago

+1 on this, it is a very annoying issue causing our travis-ci builds to fail.