dodo / node-unicodetable

unicode lookup table
MIT License
42 stars 34 forks source link

Can you put copy of UnicodeData.txt into package as fallback solution #25

Open xiaoping0x opened 7 years ago

xiaoping0x commented 7 years ago

Because company firewall, I can not download data. fallback solution will done.

MadLittleMods commented 7 years ago

Another reason to include is because unicode.org:80/Public/UNIDATA/UnicodeData.txt is timing out currently.

try to read file UnicodeData.txt … UnicodeData.txt not found. try to download … GET unicode.org:80/Public/UNIDATA/UnicodeData.txt Error while downloading UnicodeData.txt: Error: connect ETIMEDOUT 216.97.88.9:80 Please download file manually, put it next to the install.js file and run node install.js again.

mwj8410 commented 7 years ago

It's been breaking our builds intermittently for 2 days now. We had to remove the modules that depended on this package because it has such a low likelihood of being repaired based on the maintainer's activity.

For us, this package was 4 dependencies deep.

tomfirebox commented 7 years ago

Is this temporarily fixed by downloading the UnicodeData.txt file and setting the NODE_UNICODETABLE_UNICODEDATA_TXT variable?

schmidsi commented 7 years ago

@tomhvy yes!

We solved it by downloading UnicodeData.txt from github.com/openjdk-mirror and setting the NODE_UNICODETABLE_UNICODEDATA_TXT environment variable locally.

For Mac OS X it works like this: Add a new line to ~/.bash_profile with the following content:

export NODE_UNICODETABLE_UNICODEDATA_TXT=/PATH/TO/UnicodeData.txt

(Replace "PATH/TO" with the actual path 😉)

That said, I am unhappy with the package ATM regarding this issue and the security problems that this behaviour introduces, discussed here: #27

Exomnius commented 7 years ago

Same issue. Since 2 days our build environment on AWS gets a timeout while retrieving the unicodeData.txt. Thanks @schmidsi for the temporary solution.

Saturate commented 7 years ago

We got blocked from the UNICODE website due to a large amount of downloads for this file. So it's a good idea to embed it in this project, as all our builds stopped working.

tdanecker commented 7 years ago

Hi there,

I'm trying to escalate the issue to the npmjs support team.

See also my comment at https://github.com/dodo/node-unicodetable/issues/27#issuecomment-289486250

tdanecker commented 7 years ago

I just want to inform you, that the new version has been released! (see https://github.com/dodo/node-unicodetable/issues/27#issuecomment-291469699)

If you maintain any packages depending on this one, you can update to the new version. The slug package should update automatically.