search

dodona-edu / dodona

🧑‍💻 Learn to code for secondary and higher education
https://dodona.be
MIT License
70 stars 23 forks source link

API /notifications.json has field ..._url but shows ..._path #5286

Closed BWindey closed 1 month ago

BWindey commented 10 months ago

When looking at the output of dodona.be/notifications.json, I notice that the field "notifiable_url" does not contain a url, but a path (doesn't contain "https://dodona.be"). This is inconsistent with other json pages.

image The 2 files that create the result: https://github.com/dodona-edu/dodona/blob/main/app/views/notifications/_notification.json.jbuilder#3 https://github.com/dodona-edu/dodona/blob/main/app/helpers/notifications_helper.rb#9

BWindey commented 1 month ago

Was this fixed, or deemed unwanted?

bmesuere commented 1 month ago

Fixing this might break things, so it's not worth the fix.