dodona-edu / judge-html

🌐 HTML&CSS judge for the Dodona learning environment
GNU Affero General Public License v3.0
3 stars 1 forks source link

Reset CSS for student submission render #190

Open BTWS2 opened 3 years ago

BTWS2 commented 3 years ago

The difference between the render with clean CSS and the render on Dodona isn't beneficial for the students. If the render is not reliable, a separate editor is required and it is less user-friendly.

If teachers want to grade HTML&CSS exercises it's easier if the render is reliable.

Rowspan isn't visible in this example. table_5 fullname

The Dodona doesn't support iframes in the student submission render.

@bmesuere suggests these options:

tag { all: unset; } / or */

tag * { all: revert; }


  Docs: 
  https://developer.mozilla.org/en-US/docs/Web/CSS/all

  Edit: Tested without the desired result.

* Solve with iframe
> "alles wat je in die ruby file opgeeft zal geoutput worden naar html je moet 2 dingen outputten:
 > een lege iframe (bv met een id, hoogte en breedte opgegeven)
 > en dan een script tag waar je bv via document.getElementById de iframe selecteert en dan de srcdoc property instelt" - Bart

> "Iframe is miserie omdat je bv de hoogte niet automatisch goed krijgt en dan moet je JavaScript truuken uithalen om dat te fixen" - Bart
stijndcl commented 3 years ago

If the render is not reliable, a separate editor is required and it is less user-friendly.

Dodona is not an IDE, so a separate editor is required either way. Students shouldn't be coding in Dodona.