search

dodona-edu / universal-judge

Universal judge for educational software testing
https://docs.dodona.be/en/tested
MIT License
9 stars 4 forks source link

Do not add newlines to empty strings #501

Closed niknetniko closed 4 months ago

niknetniko commented 4 months ago

When updating the documentation, it occurred to me that we currently also append newlines to empty strings for stdout/stderr. This is probably not what we want (since an empty stdout/stderr is perfectly fine), and also not how POSIX defines a file (zero or more lines).

pdawyndt commented 4 months ago

I actually ran into this issue for one of the JavaScript exercises: after changing the newline handling, there was a single test suite that had expected stderr specified as the empty string. I had to remove the specification of stderr (which was actually not needed) for exactly the reason that was mentioned here. The fix would have indeed resolved the issue as well.