doe300 / VC4C

Compiler for the VC4CL OpenCL implementation
MIT License
118 stars 37 forks source link

Rewrite optimization management (see #75) #83

Closed doe300 closed 6 years ago

doe300 commented 6 years ago

Closes #75

nomaddo commented 6 years ago

It's ok for me to disable or enable optimizations by your commit. But, for setting parameters, it's not convinient.

Now only the threshold of combineLoadLiterals can be adjusted by passing parameter. In this implementation, --fcombine-loads=1000 can set the threshold. It works, but in near future

Then, the name of option for that will be strange for users. I think there is no beautiful way to solve the problem. It's better to do like previous way.

nomaddo commented 6 years ago

I like the way how to add parameters adjusted by compilation options except one point I wrote. After solving this, we can merge it.

nomaddo commented 6 years ago

Seems good to me +1