search

doesntmattr / mongodb-migrations-bundle

Symfony MongoDBMigrationsBundle
MIT License
23 stars 27 forks source link

AntiMattrCommand is not a Command #2

Closed redthor closed 8 years ago

redthor commented 8 years ago

Looking at #1 I just noticed that: Command/AntiMattrCommand is not really a Command.

It extends ContainerAwareCommand but does not appear to use anything in that class.

I suggest that:

We might be able to change it to a trait? (I haven't thought that through, and we'd need to change php minimum to 5.4)

Here is the class: https://github.com/doesntmattr/mongodb-migrations-bundle/blob/master/Command/AntiMattrCommand.php#L24

caciobanu commented 8 years ago

At a first look that class is not extended at all, but I have to check to be sure. It is used directly in the other command classes: https://github.com/doesntmattr/mongodb-migrations-bundle/blob/master/Command/MigrationsExecuteCommand.php#L36 Making it a helper could be a good idea. I'll think about it.

For the PHP version I suggest keeping compatible with the lowest version required by the Symfony supported versions. For now Symfony 2.8 (LTS) requires PHP 5.3.9.

redthor commented 8 years ago

Ok, agreed. Leave out traits, but change it to be a helper. I'll look into it.

redthor commented 8 years ago

See #3