dofuuz / python-soxr

Fast and high quality sample-rate conversion library for Python
Other
78 stars 6 forks source link

Support aarch64 with cibuildwheel==2.1.1 #4

Closed kimdwkimdw closed 3 years ago

kimdwkimdw commented 3 years ago

Need arm64 build like another libraries(ex. matplotlib). @dofuuz

reference: https://github.com/pypa/cibuildwheel https://github.com/matplotlib/matplotlib/blob/master/.github/workflows/cibuildwheel.yml#L11

dofuuz commented 3 years ago

Thank you for contribution.

I added ARM64 wheel with my code. https://pypi.org/project/soxr/0.2.6/

Can you confirm it works for your needs?

kimdwkimdw commented 3 years ago

Thank you for contribution.

I added ARM64 wheel with my code. https://pypi.org/project/soxr/0.2.6/

Can you confirm it works for your needs?

It works for arm64. thanks!

PR is ready to merge!

dofuuz commented 3 years ago

Sorry, I'm not going to merge this PR. ARM64 is added with other way😉 https://github.com/dofuuz/python-soxr/commit/a83eea0f8e38901a67b43f20270f01aa84ddb816 Anyway, now you can use soxr>=0.2.6 from pip with prebuilt ARM64 binaries.

kimdwkimdw commented 3 years ago

Great! Thanks!