search

dogancelik / irccloud-sws

✏️ Enables text styles in IRCCloud
MIT License
21 stars 6 forks source link

Markdown mode affects links #13

Open Chew opened 6 years ago

Chew commented 6 years ago
30ff9fd146a361a4ee62e0d04878ef97

turns into

013454c90c91a1ccd7478d3aa8ffd615
jclishman commented 6 years ago

Also effects emotes: What I typed

What it output

Maybe add a toggle to only use */** for italics/bold?

I don't see why italics would need to be triggered by both * and _

advaith1 commented 6 years ago

@jclishman: Italics used to only be triggered with *, but since markdown also accepts _ for underline and I was used to using it, I added it in a PR.

@Chewsterchew are all the issues you make based on stuff I did in chat, lol

Chew commented 6 years ago

None of them are actually.

advaith1 commented 6 years ago

you want me to get screenshots?

Chew commented 6 years ago

I mean what point would it prove?

advaith1 commented 6 years ago

Maybe add / to escape? That would be a solution to some cases where _ is not meant to italicize

But of course, detecting links should also be implemented.

jclishman commented 6 years ago

Yes, exactly what I was thinking.

advaith1 commented 6 years ago

15