dogecash / dogecash-old

DogeCash Core Code
MIT License
31 stars 20 forks source link

listsinceblock #34

Open mister-game opened 4 years ago

mister-game commented 4 years ago

listsinceblock, debug console, causes crash

akshaynexus commented 4 years ago

please describe a way to reproduce the crash

mister-game commented 4 years ago

simply type listsinceblock in the debug console, wait 30 seconds and try to move cursor

On Mon, Nov 25, 2019 at 1:16 AM Akshay CM notifications@github.com wrote:

please describe a way to reproduce the crash

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dogecash/dogecash/issues/34?email_source=notifications&email_token=AN3OTC2GIUJIGAVKCBB7SVDQVKZF7A5CNFSM4JQ4UKZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFAQFTI#issuecomment-557908685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3OTC5Y5Y74SXQOJCOCYIDQVKZF7ANCNFSM4JQ4UKZQ .

AzrielJale commented 4 years ago

thats not full command listsinceblock ( "blockhash" target-confirmations includeWatchonly) i assume you have to give it target blockhash. or it goes haywire.

but still, shouldnt crash the wallet.

mister-game commented 4 years ago

There's also no error message saying that more information is needed

On Tue, Dec 3, 2019, 11:40 AM AzrielJale notifications@github.com wrote:

thats not full command listsinceblock ( "blockhash" target-confirmations includeWatchonly) i assume you have to give it target blockhash. or it goes haywire.

but still, shouldnt crash the wallet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dogecash/dogecash/issues/34?email_source=notifications&email_token=AN3OTC4QFNJSXX3BWLSGZILQWXIKZA5CNFSM4JQ4UKZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFX7EPI#issuecomment-560984637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3OTCYA27PO5L5XHIVZL2LQWXIKZANCNFSM4JQ4UKZQ .

AzrielJale commented 4 years ago

yeah, it seems to just drop the wallet. also happens on 5.1.1

mister-game commented 4 years ago

maybe just delete the command entirely. The only reason I cam across it is because I was going thru all the LIST......XXXX'S

On Wed, Dec 4, 2019 at 4:44 PM AzrielJale notifications@github.com wrote:

yeah, it seems to just drop the wallet. also happens on 5.1.1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dogecash/dogecash/issues/34?email_source=notifications&email_token=AN3OTC435A6WBTYXAYSJ5ULQW5UVNA5CNFSM4JQ4UKZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4GAQA#issuecomment-561537088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3OTC3SCFG4WVQOM6DHRALQW5UVNANCNFSM4JQ4UKZQ .

Liquid369 commented 4 years ago

listsinceblock itself is actually able to accept an empty parameter and should list a greater range WITHOUT a parameter in listsinceblock would start from block 0 until now and listing the entirety of transactions since the start of the chain. Maybe itself that should be limited to ONLY a block hash as for how far we are into the chain now that is too much data to process causing the crash.

Is using it WITH a blockhash causing a crash still?

mister-game commented 4 years ago

listsincelastblock, worked ok with a recent hash. This is not important to me. I have never used this command and cannot think of an instance where I would. Maybe force it to take parameter?