dogecoin / dogecoin

very currency
MIT License
14.52k stars 2.86k forks source link

listaccounts doesn't include mined amounts #151

Closed dooglus closed 10 years ago

dooglus commented 10 years ago

If I mine using p2pool, the payouts from the pool are directly in the mined block's rewards.

I have a bunch of different accounts in my wallet, and have people mining to several of them. None of them show up in the 'dogecoind listaccounts' output.

In src/bitcoinrpc.cpp we see:

        mapAccountBalances[""] += nGeneratedMature;

This means that all mined coins are credited to the default "" account, not to the account which owns the address they belong to.

This has been fixed in bitcoind. The corresponding function, now in src/rpcwallet.cpp doesn't have this special case that files mined amounts in the wrong account.

Would it be possible to either fork dogecoin from a more up-to-date version of bitcoin or backport some of the bugfixes?

dooglus commented 10 years ago

This is the fix for the bug, dated Sat Jun 2 02:33:28 2012:

https://github.com/gavinandresen/bitcoin-git/commit/e07c8e9123aa87b7d49c08a7558ea5af63bfcb74

ummjackson commented 10 years ago

We've updated to the latest Litecoin code base over @ https://github.com/ummjackson/dogecoin-1_5_alpha

This will be merged into the main dogecoin repo in the near future with the 1.5 final release.