search

dogecoin / dogecoin

very currency
MIT License
14.4k stars 2.8k forks source link

build: remove qt4 from macros #3465

Closed patricklodder closed 2 months ago

patricklodder commented 2 months ago

Removes Qt4 from bitcoin_qt.m4, so that the build fails at configuration when no Qt5 is found.

The result is that ./configure on a system where only Qt4 is installed fails with:

configure: error: Qt dependencies not found

Note that this retains most now-single-option conditionals intact, as those could be helpful for future Qt6 adoption. As an exception to this, I've removed the condition around Widgets and PrintSupportPlugin as those were only conditional because Qt4 doesn't have these modules, but for Qt5 and onward they are mandatory.

This can be done independently from #3462

chromatic commented 2 months ago

Do you have a system in mind where only Qt4 is available? Asking for a friend who is comfortable writing his own Dockerfile to test that case too.

patricklodder commented 2 months ago

Do you have a system in mind where only Qt4 is available?

You can test Qt4 with Debian 10 (final Debian version where that was shipped) and simply not install Qt5.

Asking for a friend who is comfortable writing his own Dockerfile to test that case too.

No need to write another Dockerfile - I provided one a few weeks ago with #3427

chromatic commented 2 months ago

With that Dockerfile, I see as expected:

configure: error: Qt dependencies not found