Remove BIP70 payment requests

dogecoin / dogecoin

very currency

MIT License

14.4k stars 2.8k forks source link

Remove BIP70 payment requests #3466

Open patricklodder opened 2 months ago

patricklodder commented 2 months ago

Removes:

all BIP70 functionality, while fully retaining BIP21 functionality
all BIP70 tests and the compatibility test for protobuf's bswap_16, bswap_32 and bswap_64
protobuf as a compile-time requirement

This does not (yet) change:

the depends system
documentation

Besides CI targets, I've tested this extensively on macOS and some Ubuntu Jammy with Qt 5.12.

Should get extensive review, and it would be good to wait a little with moving forward with this in case we get any feedback re: BIP70 removal from the 1.14.7 release.

patricklodder commented 2 months ago

Found 3 issues with remaining OpenSSL/proxy includes while cleaning up depends. Added these separately.

patricklodder commented 1 month ago

Squashed the additional commits. The pre-squash version of this PR can be found at patricklodder:3466-iter-1.

I think this is as ready for review as it will get, assuming 3 PRs:

changing code and build system (this PR)
depends system (#3474)
docs (tbd)

chromatic commented 1 month ago

All tests pass on x86-64. Conditional approval, provided an answer to the question about label length and the removal of --enable-bip70 from src/init.cpp's help message.

patricklodder commented 1 month ago

the removal of --enable-bip70 from src/init.cpp

Thanks! Removed.