dogecoin / dogecoin

very currency
MIT License
14.4k stars 2.8k forks source link

backport: fs wrapper #3488

Closed patricklodder closed 1 month ago

patricklodder commented 1 month ago

This backports the fs wrapper facility from Bitcoin Core that enables us to do a number of future enhancements, like allowing windows datadir paths in different codepages and allowing a means to ease a switch between boost::filesystem and std::filesystem (with c++17).

Backported commits:

Manually executed:

This is split off from #3229 and a prerequisite for that.

chromatic commented 1 month ago

Concept ACK, I like what I see on a skim. It'll take some time to get to this in detail, but I'm +1 so far.

chromatic commented 1 month ago

All tests pass on x86-64 Linux, so I'll review the commits next.