search

dogecoin / dogecoin

very currency
MIT License
14.39k stars 2.79k forks source link

libdogecoinconsensus shared library #3515

Open patricklodder opened 3 weeks ago

patricklodder commented 3 weeks ago

Originally posted by @daank-c in https://github.com/dogecoin/dogecoin/issues/3513#issuecomment-2045868757

[..] it would make me more comfortable if there was at least a label at the top of the [shared_libraries.md] document saying "this library is not actively maintained" or something to make it obvious that it's not useful at the moment. I just wouldn't want to see anyone waste their time or become confused by reading it.

For 1.15, we should either:

  1. Fix the libdogecoinconsensus library and/or docs
  2. Deprecate the libdogecoinconsensus library (can also be done in combination with the above)
  3. If neither gets done, tag the documentation as nonsensical.

I personally prefer not to resort to the third option, but this is a reminder that something has to be done.

slightlyskepticalpotat commented 3 weeks ago

Is there anything that currently depends on the library, whether in Dogecoin Core or elsewhere? A quick GitHub search doesn't reveal anything.

patricklodder commented 3 weeks ago

It's not used by Dogecoin Core: it's a shared library that exposes consensus-relevant functions from src/script to anyone that wants to use it. I don't know of anyone that uses it nowadays, but deprecation can trigger a response to that. We don't have to decide on this today, can give this a few months and see if anyone speaks up.

georgeartem commented 6 days ago

Can someone do a cliff notes version of what libdogecoin is and its purpose? Is this a middleware framework?Sent from my iPhoneOn Apr 11, 2024, at 2:05 PM, Old Dip Tracker @.***> wrote: It's not used by Dogecoin Core: it's a shared library that exposes consensus-relevant functions from src/script to anyone that wants to use it. I don't know of anyone that uses it nowadays, but deprecation can trigger a response to that. We don't have to decide on this today, can give this a few months and see if anyone speaks up.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

georgeartem commented 6 days ago

I think Paulo knows a lot about this if I remember right.Sent from my iPhoneOn Apr 25, 2024, at 9:59 PM, George Artem @.> wrote:Can someone do a cliff notes version of what libdogecoin is and its purpose? Is this a middleware framework?Sent from my iPhoneOn Apr 11, 2024, at 2:05 PM, Old Dip Tracker @.> wrote: It's not used by Dogecoin Core: it's a shared library that exposes consensus-relevant functions from src/script to anyone that wants to use it. I don't know of anyone that uses it nowadays, but deprecation can trigger a response to that. We don't have to decide on this today, can give this a few months and see if anyone speaks up.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>