search

dogecoin / libdohj

Java library for adding altcoin support to bitcoinj
Apache License 2.0
109 stars 89 forks source link

Namecoin: add LevelDBTransactionCache algorithm. #27

Closed JeremyRand closed 6 years ago

JeremyRand commented 7 years ago

This Namecoin name lookup algorithm locally caches the unspent name set using LevelDB; it downloads all headers and the most recent year's full blocks.

JeremyRand commented 7 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

Ross Nicoll:

Would like to improve exception handling - I've sketched out some comments, can you tackle them and I'll then go back over and probably raise a PR with some further tweaks. Mostly good to narrow down the exception types being thrown, and avoiding unnecessary try-catching.

Thanks for the review. I think I've made the necessary fixes.

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJZbbOMAAoJELPy0WV4bWVw7UcP/j9i5ksROinbC9TRi7wqUUmB QM/P5olcB0EZWJ7uhF9Pyat6mvX/ySTN8N/Z8gaFe9vM4v/1+wyDIcFW4XuHk7S0 fkgL3ELEvy90ful5vbpsTOFVj43mkPTpvkpcYpWj1cCZ0cLL9z5P04LldPtqNFRn MQBKttt7vQIwoGrihumVF7+iJSH+/N4Y9i/u7avSrloygXs63Iz9OUdSYwFHCz4m NZiv+Iry8HCjoPfwRbEWIz1kV5OvXuZauTkE5wNX9VGtvv1sithBJtIdCJeJr/rJ OpyX6z6qlgmR+KQpH4WrDtIKmozJ8BcW3ErTjlS3YvlPtToGzgAlVU3wyGipApo+ FDKnPX3XYTlQYluVc90vtmGONsw/PpzAmi3DX3GWkOFoZf4hpXyuHnROC9Q7Te7e 0TRhKyinGS3YmikK6N3whwOaqOLBO5+z3xzh52qKk6fdHA/wglTMrQROGFC3WWkM 8PVZ4Wg1vS5fefQ2f3iGSqJ2RYLjmYznLVYmaqxasF6hzyk9tW/et0ZltvqUPMUE HyOz9fpmjlA84kuJztLxvWiO0gTYPFLxI1DGTi23+Hk+0wIK4yiHmpba8Tc08Ljq yEYqni0h+7RBTlMpgNm/ZdzXUZaRMF3YuAiUgog4L6O88lULWE+P8HyxYJZLOWi/ 85fC1K88xFtNTjHaa1vW =0Q94 -----END PGP SIGNATURE-----

JeremyRand commented 6 years ago

@rnicoll is anything else needed on my end for this?

rnicoll commented 6 years ago

Oops, sorry, missed that coming back, will merge now