search

dogecoinfoundation / dogecoin.com

Repository for the recently redesigned dogecoin.com
https://dogecoin.com
MIT License
36 stars 44 forks source link

New Wallets Page Final #162

Closed qlpqlp closed 2 years ago

qlpqlp commented 2 years ago
qlpqlp commented 2 years ago

Can't comment on every single language... but: In summary

  • "Coinbase" absolutely needs to be "Coinbase Wallet App" not just "Coinbase". Coinbase as a service/site is custodial, and is of course easily confused with the Coinbase Wallet App (which we are listing), which is self/non custodial. (There's even a Coinbase App that is not the Coinbase Wallet App which links to the custodial service.) We have to be specific fully as "Coinbase Wallet App".

-Langerhans' / Max's wallet should not be listed anymore IMO because it is very much not supported and hasn't been developed for many years. This is by Max's own admission/opinion.

OK I found the answer and the diferences :) https://wallet.coinbase.com/faq/#:~:text=The%20Coinbase%20Wallet%20app%20is,use%20the%20Coinbase%20Wallet%20app.

Will fix it now :)

michilumin commented 2 years ago

Am ok to approve this just was wondering if we're waiting on some of the changes that @xanimo suggested

qlpqlp commented 2 years ago

Am ok to approve this just was wondering if we're waiting on some of the changes that @xanimo suggested

Dono, but I applied all his suggestions , and its much better now :D

xanimo commented 2 years ago

Am ok to approve this just was wondering if we're waiting on some of the changes that @xanimo suggested

Dono, but I applied all his suggestions , and its much better now :D

Desktop layout looks great! Still have same suggestions for increasing X icon, fix 'double vision' arrows when changing sort in columns, tooltips explaining what sorting icons do and what the color rating system (Much Wow, So Good, Such Warning) means but if it'd be easier to make new issues don't let that block. They are just suggestions.

image image image image

Also I'd suggest moving the rating system above the pagination on viewport < desktop if possible? Or perhaps centering and increasing padding top if underneath the pagination. :shrug: image image

Changes you made look great though!

qlpqlp commented 2 years ago

Am ok to approve this just was wondering if we're waiting on some of the changes that @xanimo suggested

Dono, but I applied all his suggestions , and its much better now :D

Desktop layout looks great! Still have same suggestions for increasing X icon, fix 'double vision' arrows when changing sort in columns, tooltips explaining what sorting icons do and what the color rating system (Much Wow, So Good, Such Warning) means but if it'd be easier to make new issues don't let that block. They are just suggestions.

image image image image

Also I'd suggest moving the rating system above the pagination on viewport < desktop if possible? Or perhaps centering and increasing padding top if underneath the pagination. 🤷 image image

Changes you made look great though!

About the X button and doble arrow, its doesn't show on the last commit, strange that still shows to you, browser cache? (CTRL + F5 plz :P ).

I added the footer rating above :) https://github.com/dogecoinfoundation/dogecoin.com/pull/162/commits/407d412b40058a5b313af9a7fdff94efd5d9b3b8