Open gemcoder21 opened 1 year ago
I tested the wallet on my Android 11 device
App closes wen trying to enable/disable a coin or token
Can send out 1 Doge, it gives an error.
@qlpqlp thanks for providing a feedback, let me take look into it, will revert back once fixed.
Much thanks 🙂❤️
@qlpqlp thanks for providing a feedback, let me take look into it, will revert back once fixed.
Hello, I saw the new update and tested, it can send now the 1 Doge, but, if for example I want to pay 1 Doge and only have 1 Doge on the wallet, it does not send 1 Doge but only 0.99808 Doge
So, wen paying for example on our MarketPlace https://ShibeShip.com, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:
My suggestion:
wen a user wants to send all amount on the wallet, in my case 1 Doge, show a warning that it will not sent all the amount and actually change the display to the "Full Amount" minus "Network Fees" or a user will not be able to pay in a full an invoice, in our case we are using https://gigawallet.dogecoin.org to create the Dogecoin invoices on https://ShibeShip.com
So, wen paying for example on our MarketPlace https://shibeship.com/, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:
Yes, I agree that for BIP21 amount has to be what passed. We will integrate BIP21 within the next couple of weeks for btc/ltc/doge and this would work as you expected (it has to be strict rules on the protocol level).
Also, I appreciate that you have tested the app and provided feedback.
Let me know if there is anything else we should improve.
So, wen paying for example on our MarketPlace https://shibeship.com/, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:
Yes, I agree that for BIP21 amount has to be what passed. We will integrate BIP21 within the next couple of weeks for btc/ltc/doge and this would work as you expected (it has to be strict rules on the protocol level).
Also, I appreciate that you have tested the app and provided feedback.
Let me know if there is anything else we should improve.
Much thanks for all your efforts :) Great work so far on the wallet, really simple and easy to use :)
@qlpqlp according to BIP21 there is only bitcoin:
prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44?
I will start with parsing bitcoin
, litecoin
, dogecoin
, what else if there?
@qlpqlp according to BIP21 there is only
bitcoin:
prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44?I will start with parsing
bitcoin
,litecoin
,dogecoin
, what else if there?
I only know one singular universal decentralized currency, Dogecoin :P
Probably all Layer 1 cryptocurrencies (AKA Coins, not Tokens), supports BIP21 :)
@qlpqlp according to BIP21 there is only
bitcoin:
prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44? I will start with parsingbitcoin
,litecoin
,dogecoin
, what else if there?I only know one singular universal decentralized currency, Dogecoin :P
Probably all Layer 1 cryptocurrencies (AKA Coins, not Tokens), supports BIP21 :)
Can you review submission again? Both iOS and Android apps should be able to support BIP21 properly and handle your example above.
Also, this this comment we have open sourced Gem Wallet
Screenshots: