Invoice field "confirmations" is confusing

dogecoinfoundation / gigawallet

GigaWallet is the backend for your Dogecoin Business.

https://gigawallet.dogecoin.org

MIT License

56 stars 11 forks source link

Invoice field "confirmations" is confusing #87

Closed raffecat closed 1 year ago

raffecat commented 1 year ago

It's actually an input for the required number of confirmations. But core already has a field named "confirmations" that tells you how many confirmations a block or transaction has. So it's going to confuse a lot of people.

tjstebbing commented 1 year ago

see #93 I renamed the input to required_confirmations ?

tjstebbing commented 1 year ago

fixed :)