search

doghappy / socket.io-client-csharp

socket.io-client implemention for .NET
MIT License
729 stars 125 forks source link

EioHandler UnitTests outdated #229

Closed PranKe01 closed 2 years ago

PranKe01 commented 2 years ago

Hi, there are EioHandlerTests which use the removed EioHandler classes. I think you should rmeove the whole folder or update the tests. Same applies for all the tests in the SocketIOTests folder, which use the removed WebSocketClient class. And you have a typo in the code: _connectionTokenSorce

doghappy commented 2 years ago

I think you should remove the whole folder

exactly, I will delete it when I have time, and welcome to create pr

doghappy commented 2 years ago

https://github.com/doghappy/socket.io-client-csharp/commit/a9da35eeec02052596de936af11ced19c57f3721
https://github.com/doghappy/socket.io-client-csharp/commit/dfe877ed92f0d816b13317c51ef3efe97887e61a