dogi / ole--vagrant-community

0 stars 19 forks source link

added uninstall script #21

Closed Hulmani closed 7 years ago

Hulmani commented 8 years ago

works when virtualbox and vagrant are installed via brew cask

Hulmani commented 8 years ago

Bell-app need to be signed from an identified developer in order to launch without permissions from the user.

DrewPerlman commented 7 years ago

@Hulmani The uninstall.sh file looks fine, but I'm not entirely sure what the other 38 file changes are for.

Please undo those changes (I recommend using git branches) and submit a different pull request with those changes if you'd like.

Hulmani commented 7 years ago

It has Bell-app files also. Did you also consider that?

DrewPerlman commented 7 years ago

So are those "Bell-app" files the desktop shortcut for Macs?

If so, we'd like you to do a separate pull request with only those changes (this should help you with how to do that, using git rebase, git reset, git add and such), and make this PR only have the uninstall.sh change. Also, it would be great if you named the "Bell-app" commit to something more clear (like "add Mac desktop shortcut" for example).

Hulmani commented 7 years ago

@dogi Please check if this pull request looks good

dogi commented 7 years ago

awesome