search

dogmatiq / verity

🚧 An event-sourced Dogma engine.
MIT License
2 stars 2 forks source link

Coverage flapping. #188

Open jmalloc opened 4 years ago

jmalloc commented 4 years ago

There's some time-sensitive test somewhere (I suspect in the pipeline/queue package) that's taking a different code-branch some of the time and causing coverage to flap about.

This manifests as failed codecov reports for PRs that have 100% diff coverage, like #187.

jmalloc commented 4 years ago

Ok, I've found at least one of these lines. I doubt it's the only one; I'll start a list.

jmalloc commented 4 years ago

Reopened, updated list.

jmalloc commented 4 years ago

Ok, something very strange is going on. The builds finish and Codecov reports a coverage failure because some coverage has dropped. But then they change the status to passing?

jmalloc commented 4 years ago

Many of the tests have been refactored, and this issue does not appear to be happening any longer.

jmalloc commented 4 years ago

I can't win with this one! This line is flapping now:

https://codecov.io/gh/dogmatiq/infix/compare/1780c5321d24e3a3040ffb87277ceab3dfd9a251...489a2037c120b8ba695985dca69c7a588c2b3bbd/changes