didHideMenuViewController delegate is never called.

dogo / AKSideMenu

Beautiful iOS side menu library with parallax effect. Written in Swift

MIT License

281 stars 50 forks source link

Closed santoshbista closed 5 years ago

santoshbista commented 5 years ago

[x] I have verified there are no duplicate active or recent bugs, questions, or requests

willHideMenuViewController delegate is being called instead of didHideMenuViewController.

dogo commented 5 years ago

Wow nice catch, I will fix this tomorrow

dogo commented 5 years ago

Done, @santoshrajbista please test the develop branch

santoshbista commented 5 years ago

@dogo Thank you for the fix. didHideMenuViewController is called as expected now.

But it crashes when you have only one menu view controller. Does not crash if you provide both left and right menu view controllers.

dogo commented 5 years ago

Could not reproduce @santoshrajbista

santoshbista commented 5 years ago

@dogo It appears to work fine. Sorry. I wonder what made my code crash then. It's working fine now.

dogo commented 5 years ago

No problem, glad to help