search

dogodigi / opendispatcher

First responder HTML5 nodejs client application
http://www.opendispatcher.org
GNU General Public License v3.0
2 stars 8 forks source link

Style use feature attributes #419

Closed matthijsln closed 9 years ago

matthijsln commented 9 years ago

Style for brandweervoorziening did not use radius attribute of feature but always the default value because of incorrect reference (feature.radius instead of feature.attributes.radius). Same for size of tekstobject style.

Error caught by @ankeur

matthijsln commented 9 years ago

First comment was only for the last commit, first three commits are small fixes.

milovanderlinden commented 9 years ago

This additionalModules fix causes a conflict as other projects do not have additionalModules defined in the configuration. Why are the additionalModules not simply modules? What makes them additional?

Can you explain to me what should be set in general to prevent the functionality breaking because additionalModules is undefined?

matthijsln commented 9 years ago

Ah oke, check vergeten indien additionalModules undefined is. Wordt gebruikt voor een offline voertuigviewer werkend op dezelfde database als een kantoorviewer waarin sommige modules geen zin hebben (zoals geolocate).

matthijsln commented 8 years ago

De expressie "(dbkjs.options.additionalModules && $.inArray(mod_index, dbkjs.options.additionalModules)" moet vanwege boolean-short circuiting geen fout geven indien deze niet gedefinieerd is, dus ik snap niet waarom dit een conflict veroorzaakt?