search

dogsheep / dogsheep-photos

Upload your photos to S3 and import metadata about them into a SQLite database
Apache License 2.0
170 stars 15 forks source link

Only install osxphotos if running on macOS #17

Closed simonw closed 4 years ago

simonw commented 4 years ago

The build is broken right now because you can't pip install osxphotos on Ubuntu.

simonw commented 4 years ago

https://www.python.org/dev/peps/pep-0508/#environment-markers I think I want sys_platform of darwin.

simonw commented 4 years ago

From https://hynek.me/articles/conditional-python-dependencies/ I think this will look like:

setup(
    # ...
    install_requires=[
        # ...
        "osxphotos>=0.28.13 ; sys_platform=='darwin'",
    ]
)
RhetTbull commented 4 years ago

FYI, I've got an issue to make osxphotos cross-platform but it's low on my priority list. About 90% of the functionality could be done cross-platform but right now the MacOS specific stuff is embedded throughout and would take some work. Though I try to minimize it, there's sprinklings of ObjC & Applescript throughout osxphotos.