Open RhetTbull opened 3 years ago
Fixes the issue mentioned here: https://github.com/dogsheep/dogsheep-photos/issues/15#issuecomment-748436115
👋 could I help somehow for this to be merged? As Big Sur is going to be more used as the time goes I think it would be nice to merge and publish a new version. Nice work!
I would love this merged!
👋 Any update on getting this merged?
Alternatively, is there a work around for this issue to unblock myself?
edit to add: huge fan of both this project and osxphotos
, thanks so much for your work here 🙏 If I had any experience with Python I would offer to help but somehow I've managed to not write any Python in 10+ years of programming 😅
Edit again to add:
Alternatively, is there a work around for this issue to unblock myself?
Yes, there is. I was able to apply the patch of this PR and it applies (mostly) cleanly and works.
osxphotos
.patch
to the URL)setup.py
changescd
to the directory containing dogsheep-photos
and git apply 31.patch
I just tried this branch and saw some errors.
I installed this PR locally with:
pip install https://github.com/RhetTbull/dogsheep-photos/archive/update_for_bigsur.zip
+1 to getting this merged down.
For future googlers, I installed by...
git clone git@github.com:RhetTbull/dogsheep-photos.git
cd dogsheep-photos
git checkout update_for_bigsur
python setup.py install
You can also install this with pip using this oneliner:
pip install git+https://github.com/RhetTbull/dogsheep-photos.git@update_for_bigsur
Refactored out the SQL for extracting aesthetic scores to use osxphotos -- adds compatbility for Big Sur via osxphotos which has been updated for new table names in Big Sur. Have not yet refactored the SQL for extracting labels which is still compatible with Big Sur.