search

dogtagpki / pki

The Dogtag Certificate System is an enterprise-class Certificate Authority (CA) which supports all aspects of certificate lifecycle management, including key archival, OCSP and smartcard management.
https://www.dogtagpki.org
GNU General Public License v2.0
363 stars 135 forks source link

Drop ClonesConnectivyAndDataCheck from pki-healthcheck #4843

Closed edewata closed 3 weeks ago

edewata commented 3 weeks ago

pki-healthcheck is a tool to check the status of an instance or a node in a cluster so that if it reports a problem the admin can fix it or the monitoring service can replace it with a new node.

The ClonesConnectivyAndDataCheck on the other hand is a plugin that checks the connectivity from the instance to other clones. This plugin will report a problem if another clone is down even though the instance itself is fine, which would be misleading. Since it doesn't really fit the purpose of pki-healthcheck this plugin has been dropped.

Note:

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

edewata commented 3 weeks ago

@fmarco76 Thanks! I've also fixed some tests affected by this change.

flo-renaud commented 1 week ago

@edewata this change introduces a regression in our tests because we have one test that calls ipa-healthcheck --source pki.server.healthcheck.clones.connectivity_and_data and now it fails with Source 'pki.server.healthcheck.clones.connectivity_and_data' not found (see details). I will adapt our test code but need to know for which version of PKI this change is targeted. Will it be PKI 11.6 only?