dohaduong / pe

0 stars 0 forks source link

Missing user stories for important features in DG #13

Open dohaduong opened 1 year ago

dohaduong commented 1 year ago

User stories do not cover features related to team (add person to team/create team/..), but only cover those related to contact list.

nus-pe-script commented 1 year ago

Team's Response

Both issues are talking about the missing user stories.

Severity change to low

The rationale for changing the severity to low is becuase in our UG, we gave context regarding each feature regarding teams. Therefore it provides context for both users and developers to understand our features, it is unlikely that there will be any confusion.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Important User stories missing

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Important user stories like creating a team for teammates is missing


[original: nus-cs2103-AY2223S2/pe-interim#2071] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Both issues are talking about the missing user stories.

Severity change to low

image.png

The rationale for changing the severity to low is becuase in our UG, we gave context regarding each feature regarding teams. Therefore it provides context for both users and developers to understand our features, it is unlikely that there will be any confusion. The missing user stories are low risk as they are already implemented.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Again, I believe that DG is completely different from command explanation in the UG. I agree with the team that UG and DG complement each other, however, DG also needs to include a sufficient amount of important user stories - this is for future developers and users' use and reference. The team cannot assume that missing user stories will not cause any confusion for users and developers, as this may differ for each person. Even thought their UG has covered the context, user stories are sill highly important as it helps to articulate how the app will deliver a particular value back to the target users **through simple description** - which is not something that UG's command explanation can always cover. I also disagree with the team's assumption that since UG covers everything, there is no need to include it in the DG. If everyone follows the same logic then user stories in DG would no longer be necessary and thus will be discarded for every DGs. Most importantly, in their DG, the team currently only include user stories regarding their `contact` features - which **only covers about 30%** of the total number of features they have. There are too many important user stories missing. Thus, I believe that even though missing **1-2 user stories** could be considered of **Low** severity, **missing about 70%** of the user stories should be considered **Medium** severity. This, in my opinion, is very reasonable since a team that misses 1-2 important user stories shouldn't be penalized as severely as a team that misses a lot of them. As it causes buggy behavior in numerous areas and affect future developers, the severity should be modified proportionately.