search

doherty / Dist-Zilla-PluginBundle-TestingMania

test your dist with every testing plugin conceivable
http://metacpan.org/release/Dist-Zilla-PluginBundle-TestingMania/
4 stars 6 forks source link

No default for Dist::Zilla::Plugin::ChangesTests #1

Closed mjgardner closed 13 years ago

mjgardner commented 13 years ago

The addition of DZP::ChangesTests requires a changelog attribute in dist.ini even if my changelog is named the default "Changes".

Here's the error trace:

Attribute (changelog) does not pass the type constraint because: Validation failed for 'Str' with value undef at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/Role/Plugin.pm line 50
        Dist::Zilla::Role::Plugin::plugin_from_config('Dist::Zilla::Plugin::ChangesTests', '@TestingMania/ChangesTests', 'HASH(0x376b1f8)', 'Dist::Zilla::MVP::Section=HASH(0x3756590)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/Role/Plugin.pm line 61
        Dist::Zilla::Role::Plugin::register_component('Dist::Zilla::Plugin::ChangesTests', '@TestingMania/ChangesTests', 'HASH(0x376b1f8)', 'Dist::Zilla::MVP::Section=HASH(0x3756590)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/MVP/Section.pm line 46
        Class::MOP::Class:::after('Dist::Zilla::MVP::Section=HASH(0x3756590)') called at /usr/lib/perl5/site_perl/5.10/i686-cygwin/Class/MOP/Method/Wrapped.pm line 61
        Class::MOP::Method::Wrapped::__ANON__('Dist::Zilla::MVP::Section=HASH(0x3756590)') called at /usr/lib/perl5/site_perl/5.10/i686-cygwin/Class/MOP/Method/Wrapped.pm line 89
        Dist::Zilla::MVP::Section::finalize('Dist::Zilla::MVP::Section=HASH(0x3756590)') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Assembler/WithBundles.pm line 82
        Config::MVP::Assembler::WithBundles::_add_bundle_contents('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)', 'bundle_config', 'HASH(0x3497d40)') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Assembler/WithBundles.pm line 36
        Config::MVP::Assembler::WithBundles::replace_bundle_with_contents('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)', 'Dist::Zilla::MVP::Section=HASH(0x36422c0)', 'bundle_config') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Assembler/WithBundles.pm line 26
        Class::MOP::Class:::after('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)') called at /usr/lib/perl5/site_perl/5.10/i686-cygwin/Class/MOP/Method/Wrapped.pm line 61
        Class::MOP::Method::Wrapped::__ANON__('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)') called at /usr/lib/perl5/site_perl/5.10/i686-cygwin/Class/MOP/Method/Wrapped.pm line 89
        Dist::Zilla::MVP::Assembler::end_section('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Assembler.pm line 87
        Config::MVP::Assembler::change_section('Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)', 'PerlTidy', 'PerlTidy') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Reader/INI.pm line 49
        Config::MVP::Reader::INI::INIReader::change_section('Config::MVP::Reader::INI::INIReader=HASH(0x29a1350)', 'PerlTidy') called at /usr/lib/perl5/site_perl/5.10/Config/INI/Reader.pm line 34
        Config::INI::Reader::read_handle('Config::MVP::Reader::INI::INIReader=HASH(0x29a1350)', 'IO::File=GLOB(0x29c2768)') called at /usr/lib/perl5/site_perl/5.10/Mixin/Linewise/Readers.pm line 85
        Mixin::Linewise::Readers::__ANON__() called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Reader/INI.pm line 21
        Config::MVP::Reader::INI::read_into_assembler('Config::MVP::Reader::INI=HASH(0x298f4f8)', './dist.ini', 'Dist::Zilla::MVP::Assembler::Zilla=HASH(0x293c7d0)') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Reader.pm line 19
        Config::MVP::Reader::read_config('Config::MVP::Reader::INI=HASH(0x298f4f8)', './dist.ini', 'HASH(0x29a1110)') called at /usr/lib/perl5/site_perl/5.10/Config/MVP/Reader/Finder.pm line 87
        Config::MVP::Reader::Finder::read_config('Dist::Zilla::MVP::Reader::Finder', 'Path::Class::File=HASH(0x29a10f8)', 'HASH(0x29a1110)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/Dist/Builder.pm line 187
        Dist::Zilla::Dist::Builder::__ANON__() called at /usr/lib/perl5/site_perl/5.10/Try/Tiny.pm line 76
        eval {...} called at /usr/lib/perl5/site_perl/5.10/Try/Tiny.pm line 67
        Try::Tiny::try('CODE(0x281c4c8)', 'Try::Tiny::Catch=REF(0x29a11e8)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/Dist/Builder.pm line 211
        Dist::Zilla::Dist::Builder::_load_config('Dist::Zilla::Dist::Builder', 'HASH(0x281baa8)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/Dist/Builder.pm line 27
        Dist::Zilla::Dist::Builder::from_config('Dist::Zilla::Dist::Builder', 'HASH(0x2932690)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/App.pm line 111
        Dist::Zilla::App::zilla('Dist::Zilla::App=HASH(0x21f3378)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/App/Command.pm line 13
        Dist::Zilla::App::Command::zilla('Dist::Zilla::App::Command::perltidy=HASH(0x222a218)') called at /usr/lib/perl5/site_perl/5.10/Dist/Zilla/App/Command/perltidy.pm line 23
        Dist::Zilla::App::Command::perltidy::execute('Dist::Zilla::App::Command::perltidy=HASH(0x222a218)', 'Getopt::Long::Descriptive::Opts::__OPT__::2=HASH(0x22a93c8)', 'ARRAY(0x1421f28)') called at /usr/lib/perl5/site_perl/5.10/App/Cmd.pm line 231
        App::Cmd::execute_command('Dist::Zilla::App=HASH(0x21f3378)', 'Dist::Zilla::App::Command::perltidy=HASH(0x222a218)', 'Getopt::Long::Descriptive::Opts::__OPT__::2=HASH(0x22a93c8)') called at /usr/lib/perl5/site_perl/5.10/App/Cmd.pm line 170
        App::Cmd::run('Dist::Zilla::App') called at /usr/local/bin/dzil line 11
doherty commented 13 years ago

Thank you for noticing this. I thought I had put the default in ChangesTests itself. I'll fix this shortly one way or the other.

doherty commented 13 years ago

Fixed by db4eb6f19cbd48107e910992f31e0124d38cfdc3