search

doherty / Dist-Zilla-PluginBundle-TestingMania

test your dist with every testing plugin conceivable
http://metacpan.org/release/Dist-Zilla-PluginBundle-TestingMania/
4 stars 6 forks source link

critic config #6

Closed xenoterracide closed 13 years ago

xenoterracide commented 13 years ago

Can you set Critic config with TestingMania? or should I disable it and include it on the side. (either way could you document it in the pod)

doherty commented 13 years ago

My understanding is that the actual testing library way down at the bottom of the stack doesn't support this. If I'm wrong, I'd be thrilled to hear it and add that feature.

xenoterracide commented 13 years ago

I'm a little confused... the actual test module allows you to set it, and with Test::CPAN::Changes you've managed a way to set Changelog. is critic's option so different from that?

[CriticTests]
critic_config = perlcritic.rc   ; relative to project root
doherty commented 13 years ago

Yes, it is different, actually. But, now that I know this can be accomplished, I'll see what I can do. It might involve patching more than one layer of the stack :\

xenoterracide commented 13 years ago

cool, sorry, I was just looking at it at a glance. Personally I'd be happy just to be able to specify severity, but I'm sure the config can do more.