search

dohomi / react-hook-form-mui

Material-UI form components ready to use with react-hook-form
https://react-hook-form-material-ui.vercel.app
MIT License
560 stars 111 forks source link

Correct ci.yml errors #281

Closed bethmaloney closed 4 months ago

bethmaloney commented 4 months ago

Currently the ci.yml isn't running. I've updated the ci.yml and the package.json to allow it to run. Let me know if you'd like any changes.

  1. Updated trigger to on PR or push to master instead of PR and push. This was causing the action to run twice for PRs as they involve a push to a remote branch
  2. Update node version from 20/* to 20.x. The version format has changed and 20/* isn't recognised anymore
  3. Updated build-storybook to build:storybook due to name change in command
  4. Set yarn node linker to nodeLinker: node-modules as we don't seem to be using pnp (stops it from generating the pnp js files). If we are using pnp I can revert this change
  5. Updated file: to portal: in package.json. In yarn file: causes the files to be physically copied while portal: creates a soft link. The advantage is that file: creates a hash of packages/rhf-mui which needs to be updated after building or modifying rhf-mui while portal: doesn't (less lock churn)
  6. updated build:storybook to do an install before building so that rhf-mui is available for storybook

Sorry I know there's a lot of changes but again let me know if you'd like any changes.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hook-form-material-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 0:38am