dohomi / storyblok-generate-ts

Generates TypeScript interface types based on Storyblok component file
MIT License
102 stars 33 forks source link

Fixes a bug I intro and adds Jest tests #35

Closed juanpasolano closed 1 year ago

juanpasolano commented 1 year ago

Hi @dohomi,

Why

I've recently introduced a bug in this repo on Pr #33 πŸ™ˆ . This type should not be an array since is type "option" not "options".

What

This PR fixes that bug but also adds an initial suite of tests to prevent us contributors from destroying the releases, it also includes a github action to run the test on PRs.

Caveats:

Feel free to request any changes you see fit; I appreciate you taking the time to maintain this package. Our dev experience would be horrible without it.

Screen Shot 2023-02-14 at 9 46 22 PM

dohomi commented 1 year ago

awesome thanks for taking the initiative to write some tests.. I definitely love the idea but just haven't to time for it