dohooo / react-native-reanimated-carousel

🎠 React Native swiper/carousel component, fully implemented using reanimated v2, support to iOS/Android/Web. (Swiper/Carousel)
https://react-native-reanimated-carousel.vercel.app
MIT License
2.59k stars 297 forks source link

Missing installation steps for the web when using `react-native-gesture-handler >= 2.10.0` #542

Open cglacet opened 5 months ago

cglacet commented 5 months ago

Describe the bug

Missing installation steps for react-native-gesture-handler >=2.10.0 for the web.

Fix

Include something like the following in the installation steps for the web:

If you have react-native-gesture-handler >= 2.10.0 installed, you will need to use the legacy gesture handler, this can be done by editing your web app entry point:

import { enableLegacyWebImplementation } from 'react-native-gesture-handler';

enableLegacyWebImplementation(true);

More information about the legacy implementation here Install react native gesture handler: Web

To Reproduce

Install the latest version of react-native-gesture-handler, create a Carousel and try to swipe on a touch screen. This will make items disapear.

Expected behavior

Touch events working on the web for all versions of react-native-gesture-handler.

Versions (please complete the following information):

Smartphone (please complete the following information):

dosubot[bot] commented 5 months ago

πŸ€–

Thank you for bringing this to our attention! Your proposed fix looks great and would definitely help improve the installation steps for react-native-gesture-handler on the web. We appreciate your contribution and encourage you to create a pull request with your suggested changes. Your effort will help make the installation process smoother for other users. Keep up the good work!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a πŸ‘ if this is helpful and πŸ‘Ž if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

tomashco commented 4 months ago

that solved my issue installing react-native-reanimated-carousel on web! thank you!

Describe the bug

Missing installation steps for react-native-gesture-handler >=2.10.0 for the web.

Fix

Include something like the following in the installation steps for the web:

If you have react-native-gesture-handler >= 2.10.0 installed, you will need to use the legacy gesture handler, this can be done by editing your web app entry point:

import { enableLegacyWebImplementation } from 'react-native-gesture-handler';

enableLegacyWebImplementation(true);

More information about the legacy implementation here Install react native gesture handler: Web

To Reproduce

Install the latest version of react-native-gesture-handler, create a Carousel and try to swipe on a touch screen. This will make items disapear.

Expected behavior

Touch events working on the web for all versions of react-native-gesture-handler.

Versions (please complete the following information):

* react: v18.2

* react-native: v0.72.6

* react-native-reanimated: v3.4.2

* react-native-reanimated-carousel: v3.5.1

* react-native-gesture-handler: v2.15.0

Smartphone (please complete the following information):

* Device: desktop

* Browser: Chrome (debug mobile view)

* Version: 121.0.6167.140
nikenvy commented 4 months ago

helped me too on expo!