search

dohooo / react-native-reanimated-carousel

🎠 React Native swiper/carousel component, fully implemented using reanimated v2, support to iOS/Android/Web. (Swiper/Carousel)
https://react-native-reanimated-carousel.vercel.app
MIT License
2.86k stars 329 forks source link

fix: fix carousel sizing #647

Closed itsramiel closed 3 months ago

itsramiel commented 4 months ago

Closes #646

In react-native-gesture-handler v2.16.0, a style of {flex: 1} was added to GestureHandlerRootView in this pr.

This styling leads to the issues mentioned in #646

In order to fix the issue, the width and height are set on the GestureHandlerRootView and the container has a flex: 1 to fill in the GestureHandlerRootView

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 1e505cc286706dbe05d448defdb830c59b50bd54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:15pm