fix: parallax layout with new arch enabled

dohooo / react-native-reanimated-carousel

🎠 React Native swiper/carousel component, fully implemented using reanimated v2, support to iOS/Android/Web. (Swiper/Carousel)

https://react-native-reanimated-carousel.vercel.app

MIT License

2.85k stars 329 forks source link

fix: parallax layout with new arch enabled #716

Open thibaultcapelli opened 2 weeks ago

thibaultcapelli commented 2 weeks ago

This PR fixes #715, #712

Description

Round the zIndex value in the parallax layout

Review

[x] I self-reviewed this PR

Testing

I manually tested

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: c195dcf8f4e50e6855065611cafc02072ee2a25f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-reanimated-carousel	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 5:12pm

sntg-p commented 2 weeks ago

It works, thanks!

BrodaNoel commented 1 week ago

Glad to see this. Considering that Expo will release SDK 52 in few days/hours, every New Arch fix is very welcomed.

SDK 52 will allow enable New Arch in all Expo projects

BrodaNoel commented 1 week ago

Expo SDK 52 was finally released.

This library breaks the app when scrolling using parallax. Seems like this PR is fixing the problem. It will be better to have it merge as soon as possible. This library is blocking all new releases of any app using this library