doitandbedone / ispyagentdvr-docker

GNU General Public License v3.0
119 stars 45 forks source link

No latest docker image being published #652

Open juniorfga opened 1 year ago

juniorfga commented 1 year ago

Affected Version latest

Describe the bug Since April 29th version v4.7.2.0 there is no update for doitandbedone/ispyagentdvr:latest docker image or doitandbedone/ispyagentdvr:vlc-support.

Steps To Reproduce Steps to reproduce the behavior:

  1. Do a 'docker pull doitandbedone/ispyagentdvr:latest'
    docker pull doitandbedone/ispyagentdvr:latest
    latest: Pulling from doitandbedone/ispyagentdvr
    2ab09b027e7f: Pull complete
    a9788f4a8b5e: Pull complete
    0e94a7fab283: Pull complete
    4c54dd8efa29: Pull complete
    c78df65de228: Pull complete
    4405fc9d8d75: Pull complete
    4e1d6be6b9af: Pull complete
    6072019b4d0e: Pull complete
    d2585fa6cdbf: Pull complete
    9c55e2fdd5a2: Pull complete
    Digest: sha256:e3b012053e0ee1568b81c2e81e7d78e97b54e35ba2fe7dbcb3b3ca76bf79cd64
    Status: Downloaded newer image for doitandbedone/ispyagentdvr:latest
    docker.io/doitandbedone/ispyagentdvr:latest
  2. Execute a 'docker run -it -p 8090:8090 -p 3478:3478/udp -p 50000-50010:50000-50010/udp \ -v /appdata/ispyagentdvr/config/:/agent/Media/XML/ \ -v /appdata/ispyagentdvr/media/:/agent/Media/WebServerRoot/Media/ \ -v /appdata/ispyagentdvr/commands:/agent/Commands/ \ --name ispyagentdvr doitandbedone/ispyagentdvr:latest'
    docker run -it -p 8090:8090 -p 3478:3478/udp -p 50000-50010:50000-50010/udp \
    -v /appdata/ispyagentdvr/config/:/agent/Media/XML/ \
    -v /appdata/ispyagentdvr/media/:/agent/Media/WebServerRoot/Media/ \
    -v /appdata/ispyagentdvr/commands:/agent/Commands/ \
    --name ispyagentdvr doitandbedone/ispyagentdvr:latest
    Using default media location
    Copying /agent/Content/Commands/Record on Alert.bat
    Copying /agent/Content/Commands/All On.bat
    Copying /agent/Content/Commands/Start Record.bat
    Copying /agent/Content/Commands/Stop Streaming.bat
    Copying /agent/Content/Commands/All Off.bat
    Copying /agent/Content/Commands/Stop Record.bat
    Copying /agent/Content/Commands/Snapshot.bat
    Copying /agent/Content/Commands/readme.txt
    Copying /agent/Content/Commands/Record on Detect.bat
    Copying /agent/Content/Commands/Record Off.bat
    Copying /agent/Content/Commands/Restart Agent.bat
    Copying /agent/Content/Commands/Stop Cloud Uploads.bat
    Copying /agent/Content/Commands/Alerts On.bat
    Copying /agent/Content/Commands/Apply Schedule.bat
    Copying /agent/Content/Commands/_Example.bat
    Copying /agent/Content/Commands/Alerts Off.bat
    Copying /agent/Content/Masks/demo_mask.png
    Copying /agent/Content/sounds/alsation_bark.wav
    Copying /agent/Content/sounds/doorbell.wav
    Copying /agent/Content/sounds/cairnterrierbark.wav
    Copying /agent/Content/sounds/rottweiler_bark.wav
    Copying /agent/Content/sounds/wiggle.wav
    Copying /agent/Content/sounds/alsationxsiberian_bark.wav
    Copying /agent/Content/sounds/police.wav
    Copying /agent/Content/sounds/pop.wav
    Copying /agent/Content/sounds/spanielgrowlbark.wav
    Copying /agent/Content/sounds/alarm.wav
    Copying /agent/Content/sounds/airhorn.wav
    Log start
    Agent (v4.7.2.0)
    Starting...
    Detected: Linux64
    Creating temp path for opencv in /tmp/
    Get com port list
    Using WorkStation GC
    Init FFmpeg
    Looking for ffmpeg in ffmpeg-v5/workspace/lib
    Not in there..
    Looking for ffmpeg in /usr/local/lib
    Found ffmpeg in /usr/local/lib
    ffmpeg path: /usr/local/lib
    Initializing devices
    vaapi
    Found 0 devices
    call arecord -l
    Init NDI
    Error: Init NDI: Not installed
    Preloading Images
    Turn Server accepting connections at 172.17.0.2:3478 using range 50000-50010)
    MQTT not configured or enabled
    Loaded 0 cameras and 0 mics from /agent/Media/XML/objects.xml
    Using default port (8090)
    Access locally at http://localhost:8090/
    Running at http://localhost:8090/
    IP addresses:
    172.17.0.2
    Accepting http connections at http://*:8090/
    found 172.17.0.1
    found 172.17.0.2
    ZeroConf: ZeroConf Service Started
  3. See error 'Agent (v4.7.2.0) Starting...'

Expected behavior Expected to see the latest version 5.0.1.0 being executed.

Reproduction rate 100%

Screenshots image

Host System Information (where ispy agent is running/hosted):

Client System Information (device accessing the web portal, if applicable):

Additional Information I can see here the configuration for publishing these docker image tags but this is no working

juniorfga commented 1 year ago

This behavior is being caused by not merging the PR's to master, as you can check PR 651 has not being merged to master so the GHA never get executed this because lacking of merge to master

sirweazel commented 1 year ago

Is there any reason not to update using the specific tags until the issues get fixed preventing master/latest getting published? With several releases behind, do you think i should step up my updates or just deploy the latest?

juniorfga commented 1 year ago

Currently I'm using specific updates, I'm just trying to improve your excellent work, IMHO having latest + step is the best option.

sirweazel commented 1 year ago

Not my Excellent work, but i do agree it's excellent work! I was just asking as a end user. I never realized this was "unofficial" but the ispy team mentioned a new maintainer took over a few months ago when i reached out to support.

sirweazel commented 1 year ago

I just wanted to mention that on ispyconnect's Download page, they direct you to the mekayelanik/ispyagentdvr:latest so that might be where the new maintainer is. I just pointed my config to the new location and updated. I had to reload my configs and such, and then noticed that all the photo recordings where in the GUI, but not the Video. I didn't want to spend a lot of time troubleshooting. I just wiped out my persistent storage locations, applied the config.xml and reloaded. I could have copied the video, but i honestly didn't need all the video. I then uploaded my backed up objects.xml config. Everything started and is running as expected. So if anyone attempts this, i just recommend backing up your configs both via the gui and from your persistent storage. I also had to re-enable the remote access license. When looking i noticed a ton of configs are no longer created. So it's quite possible i had some legacy configs conflicting. It's late at night in my area, and if you read my rambles...

../ the short take away is that ispy's docker instructions refer us to a new repository. The other issue after upgrading i had was with firefox and some historical cache messing things up. I ended up using another browser to configure and validate, I hope this helps other people. I do love this software.

ispyconnect instructions say to use this repo mekayelanik/ispyagentdvr:latest