Closed femrtnz closed 1 month ago
Hey @dark0dave I appreciate any insights on this change 🙏
This PR is too long, style is incorrect and introduces way too many commits. Rebase and clean this up.
Printer should not depend on config. Please don't create this binding....
Judge should not depend on config. Please don't create this binding....
Could you please detail what you mean? which file, line etc? it will be easier if you comment on the file.
Also why has the printer changed.... Like this feels brittle.
Printer should not depend on config. Please don't create this binding....
@femrtnz Read this again and now understand my pr https://github.com/doitintl/kube-no-trouble/pull/649
This pr is massive mistake. Not the functionality the way it was done.
As part of the issue #405 and and #410 , we are adding a new flag called
--labels
. This flag is not active as defaultSetting the flag
--labels=true
will include in the output a list of labels for each resource, please check the example output belowExample for TEXT output
Example for CSV output
Example for JSON output