doitsujin / dxvk

Vulkan-based implementation of D3D8, 9, 10 and 11 for Linux / Wine
zlib License
13.4k stars 866 forks source link

Stalker: Shadow of Chernobyl: Clouds visible through the roof in ver. 1.9.2 #2300

Closed onlylunix closed 3 years ago

onlylunix commented 3 years ago

Bug in version 1.9.2 Game: S.T.A.L.K.E.R SHOC Сlouds were visible through the ceiling. Version 1.9.1 does not contain this bug.

System information

Xubuntu 20.04.3

$ inxi -G Graphics: Device-1: Intel HD Graphics 630 driver: i915 v: kernel Display: x11 server: X.Org 1.20.11 driver: modesetting unloaded: fbdev,vesa resolution: 1920x1080~60Hz OpenGL: renderer: Mesa Intel HD Graphics 630 (KBL GT2) v: 4.6 Mesa 21.0.3

With dxvk v.1.9.1 or without: stalker-soc With dxvk v.1.9.2: stalker-soc-dxvk

DadSchoorse commented 3 years ago

Can you capture an apitrace?

onlylunix commented 3 years ago

need instructions on how to do it

DadSchoorse commented 3 years ago

https://github.com/Joshua-Ashton/d9vk/wiki/Making-a-Trace

onlylunix commented 3 years ago

done: https://disk.yandex.ru/d/CyGwKaILve89SQ

DadSchoorse commented 3 years ago

The trace only replays what looks to me like a part of the initial loading screen, did you actually go in-game to capture the problem while making the trace?

onlylunix commented 3 years ago

Yes, I played for a few seconds to make sure. The instructions ( https://github.com/Joshua-Ashton/d9vk/wiki/Making-a-Trace ) said to remove the dxvk, which I did. Of course, there is no bug without dxvk.

K0bin commented 3 years ago

image

That's the only thing the apitrace shows. Please try make a new one.

onlylunix commented 3 years ago

That's the only thing the apitrace shows. Please try make a new one.

done: https://disk.yandex.ru/d/OuXMoIj8aLkgoA

K0bin commented 3 years ago

Same problem with that one.

onlylunix commented 3 years ago

Same problem with that one.

ok, v3: https://disk.yandex.ru/d/25mqOo4ss8KEpQ

K0bin commented 3 years ago

Still same problem. Looks like this is an issue with the game. Unfortunately I can't fix this without a working apitrace.

Kron4ek commented 3 years ago

I have an issue in this game too with DXVK 1.9.2, not with the clouds though, but with the skybox itself.

I can't record an apitrace, wine just crashes with stack overflow if i use the apitrace's d3d9.dll. However, i found out that the bad commit is https://github.com/doitsujin/dxvk/commit/78d22cc7a5e03817ed06002f50120bfe77efcdd3, reverting it fixes the issue. Maybe this commit also causes the issue @onlylunix has.

test

K0bin commented 3 years ago

@onlylunix Is your issue also fixed if you revert that commit?

If not, can you please bisect? (Find the exact commit that caused the problem)

Kron4ek commented 3 years ago

A build with reverted https://github.com/doitsujin/dxvk/commit/78d22cc7a5e03817ed06002f50120bfe77efcdd3

dxvk-1.9.2-test.tar.gz

onlylunix commented 3 years ago

A build with reverted 78d22cc

dxvk-1.9.2-test.tar.gz

yes, it solved the bug

zaps166 commented 3 years ago

Reverting https://github.com/doitsujin/dxvk/commit/78d22cc7a5e03817ed06002f50120bfe77efcdd3 helps with other DX9 games, too (RADV, mesa 21.2.2, kernel 5.14.7).

DadSchoorse commented 3 years ago

@zaps166 what games? And can you please create an apitrace of an affected game? The revert is not fully correct because it breaks wine tests, so it would be nice if I could look into what's happening.

iWeaker commented 3 years ago

Reverting 78d22cc helps with other DX9 games, too (RADV, mesa 21.2.2, kernel 5.14.7).

With this "revert" it has a better performance in BL2, I have noticed that with version 1.9.2 of DXVK, at certain times I suffer from "fps drops + stuttering", with this commit, it fixes that problem, is what I noticed.

(NVIDIA GTX 1060 + Kernel Xanmod 5.13)

K0bin commented 3 years ago

I have noticed that with version 1.9.2 of DXVK, at certain times I suffer from "fps drops + stuttering", with this commit, it fixes that problem, is what I noticed.

It's more likely that it was just compiling shaders and those shaders were cached when you tried the build with the revert.