doitsujin / dxvk

Vulkan-based implementation of D3D8, 9, 10 and 11 for Linux / Wine
zlib License
12.56k stars 802 forks source link

Fallout 4 GOTY Godrays Flickering and Texture Bugs #2985

Open mikhaelcool7 opened 1 year ago

mikhaelcool7 commented 1 year ago

Problem

Random blurry textures covering parts of the map and sometimes even hide doors. You can easily walk through them but they can sometimes cover up useful places or even items. Godrays flicker when set to low. Higher graphical quality was not tested as it is very demanding.

Software information

Fallout 4 GOTY

System information

image image image

Blisto91 commented 1 year ago

When you say flickering you mean it can have lines like this that can move around as you move around like below screenshot?

Screenshot ![Screenshot_20221011_200844](https://user-images.githubusercontent.com/47954800/195167357-08fd5489-687b-4293-9ee9-378d46cc450f.png)

Or do you mean the light itself themselves kinda shimmer/flicker when you look at them or the sun and move the mouse like the video?

Video https://user-images.githubusercontent.com/47954800/195172830-18fb0b3f-1a99-4eac-b111-d117c900f59d.mp4
mikhaelcool7 commented 1 year ago

Both

Blisto91 commented 1 year ago

Rgr. For the texture issue does it happen in specific places or is it random

mikhaelcool7 commented 1 year ago

I haven’t gone back to those places but I will have a look tomorrow after work

Blisto91 commented 1 year ago

Made a trace of the light issue (for the devs) https://mega.nz/file/AxADFDZa#Nsv8_LNZdzYdIUo9Q-gDWYsOr1zR53LReWSerzd7Ldk

It is a bit annoying to reproduce since it seems like a race condition or something else random as it doesn't happen on every start. Same for when replaying the trace as i had to replay it like 10-15 times before it showed.

Edit: Although all of a sudden i reproducing it alot more easy in the trace for some reason and now it happens almost everytime. It also changes behavior from time to time so the two light things in my post above is actually the same issue.

doitsujin commented 1 year ago

Do we know if this is a regression? Does this only affect the GOTY edition or the regular game as well? The latter is not known to have this issue.

DXVK/Wine version: GE-Proton 7-37

Which DXVK build is that exactly?

Blisto91 commented 1 year ago

The light issue from what i can see it is not a regression. In the trace i made i saw the issue also when i replayed with dxvk 1.7. I only have the base game and there it is a issue too. GE-Proton 7-37 is dxvk f8bd19f

From time to time it can be annoying to reproduce consistently. I will try to check it out on Windows too with dxvk and also on Nvidia.

The texture issue i don't know about

mikhaelcool7 commented 1 year ago

Does this only affect the GOTY edition or the regular game as well?

They are both the same game unlike Fallout 3 and I don't think DLC has an impact. I am not using the 4K textures DLC

mbriar commented 1 year ago

Not sure if this really concludes anything, but i replayed the apitrace 100 times each with both RADV from git, RADV 22.1.7 and AMDVLK 2022.Q3.5 on a 6700XT, letting it snapshot a specific frame each run like so:

for i in $(seq -w 1 100)
do
    wine d3dretrace.exe --snapshot-prefix=/tmp/FO4/$i-run- --snapshot=4222611 --headless Fallout4.trace
done

and there were zero broken frames with AMDVLK or RADV from git, but with RADV 22.1.7 about 20/100 frames showed the broken lighting. All this was on dxvk f8bd19f210d32.

K0bin commented 1 year ago

No issues on Nvidia either.

Probably a good idea to open a Mesa issue then and ideally someone could bisect RADV.

mbriar commented 1 year ago

A bit annoying to bisect when you need to run it 100 times to be reasonably sure if the issue is there or not - would take a while even with headless apitrace, otherwise I'd have done it already. -- Sent with Tutanota, enjoy secure & ad-free emails.

12 Oct 2022, 17:40 by @.***:

Probably a good idea to open a Mesa issue then and ideally someone could bisect RADV.

— Reply to this email directly, > view it on GitHub https://github.com/doitsujin/dxvk/issues/2985#issuecomment-1276383968> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A3G6J6LLJ6VTFH6KKQCX2O3WC3LYDANCNFSM6AAAAAARCQSKQQ> . You are receiving this because you commented.> Message ID: > <doitsujin/dxvk/issues/2985/1276383968> @> github> .> com>

Blisto91 commented 1 year ago

and there were zero broken frames with AMDVLK or RADV from git, but with RADV 22.1.7 about 20/100 frames showed the broken lighting.

Thx for the heads up. I tested with 22.1.7. I will retest with mesa git as you said. If the light issue isn't a thing anymore on mesa git then there's no need to bisect.

Blisto91 commented 1 year ago

Can confirm mesa-git fixes the light issue. Nice find @mbriar So that should solve itself in a future driver update.

Should be able to focus on the geometry/texture issue instead.

Blisto91 commented 1 year ago

@mikhaelcool7 Did you get to check if the texture issue only appears in certain places? 🙂

mikhaelcool7 commented 1 year ago

@mikhaelcool7 Did you get to check if the texture issue only appears in certain places? 🙂

I was not able to replicate the texture issue while standing in the same place. Perhaps it depends on the time of day but I haven't encountered the issue since

Blisto91 commented 1 year ago

Can you show the location of one of the screenshots above? Would like to do some testing :slightly_smiling_face: Or provide a save game.

mikhaelcool7 commented 1 year ago

image Save File: Exitsave0_8C236813_4D4337_Commonwealth_001341_20221015140955_11_2.zip

Blisto91 commented 1 year ago

I've tried a few times to reproduce the issue on Deck with the save in that location, but haven't been able to.

Blisto91 commented 1 month ago

@mikhaelcool7 Friendly ping. Have you still not seen this issue since?