doitsujin / dxvk

Vulkan-based implementation of D3D8, 9, 10 and 11 for Linux / Wine
zlib License
13.44k stars 868 forks source link

Call of Duty: MWR - Graphic glitches during mission "blackout" #3073

Open gabriele2000 opened 2 years ago

gabriele2000 commented 2 years ago

Software information

Call of Duty - Modern Warfare Remastered Maximum settings except a few things. I reckon the glitch goes away if I lower the quality to minimum.

System information

Apitrace file(s)

Not created, yet.

Log files

h1_sp64_ship_dxgi.log h1_sp64_ship_d3d11.log

Video

Blisto91 commented 2 years ago

Does it also happen without the dxvk config options?

K0bin commented 2 years ago

info: d3d11.samplerAnisotropy = 16

Try it without that option. It can definitely break games.

If that doesn't work, please make an apitrace.

gabriele2000 commented 2 years ago

info: d3d11.samplerAnisotropy = 16

Try it without that option. It can definitely break games.

If that doesn't work, please make an apitrace.

I'll try it EDIT: It doesn't fix anything

gabriele2000 commented 2 years ago

If that doesn't work, please make an apitrace.

With DXVK the game is unbearably slow, it's even hard to see any glitch. Without DXVK "directX error" and I cannot apitrace anything.

K0bin commented 2 years ago

With DXVK the game is unbearably slow, it's even hard to see any glitch.

Doesn't matter, we need the apitrace.

gabriele2000 commented 2 years ago

With DXVK the game is unbearably slow, it's even hard to see any glitch.

Doesn't matter, we need the apitrace.

Even if it's with DXVK? Ok then, let's do it.

gabriele2000 commented 2 years ago

Apitrace

gabriele2000 commented 2 years ago

I'm about to try and record another apitrace, this exact type of glitches are present in other levels. This level is faster to load, less useless frames will be captured and it's more "downloadable" for you, and easier to upload for my capped data.

gabriele2000 commented 2 years ago

The shadows are the problem. If I turn them off the glitches disappear. Why?

K0bin commented 2 years ago

Can you post some screenshots? The apitrace looks fine.

image

gabriele2000 commented 2 years ago

Can you post some screenshots? The apitrace looks fine.

image

Yeah, the glitch disappear when I record the apitrace, that's just a bad joke. Anyway, I have to try with a recent version of the game, I guess it's an issue with the game.

Blisto91 commented 2 years ago

Adding to the issue that i can reproduce it ingame. Haven't found it to be a regression as it was the same with dxvk 1.0. The issue appears when you have shadows turned on plus "CACHE SUN SHADOW MAPS" turned off. If you turn off shadows it seems to go away and if you have shadows on then turning on "CACHE SUN SHADOW MAPS" also seemed to make it go away.

This is on a R9 380

gabriele2000 commented 2 years ago

turning on "CACHE SUN SHADOW MAPS" also seemed to make it go away.

Jesus, that option will just use so much VRAM that'll kill my smooth performance... Anyway, regression, how? What's exactly the culprit, DXVK-wise, I mean.

Blisto91 commented 2 years ago

Anyway, regression, how?

No i meant it isn't a dxvk regression as it appeared in even the oldest dxvk versions i tried.

What's exactly the culprit, DXVK-wise, I mean.

No idea as i have no technical knowledge about this and just try to help testing :grin: Also when it's buggy in this game section it has a tendency to freeze my entire graphical output so i had to force down my pc quite alot when testing this lol.

gabriele2000 commented 2 years ago

Anyway, regression, how?

No i meant it isn't a dxvk regression as it appeared in even the oldest dxvk versions i tried.

What's exactly the culprit, DXVK-wise, I mean.

No idea as i have no technical knowledge about this and just try to help testing grin Also when it's buggy in this game section it has a tendency to freeze my entire graphical output so i had to force down my pc quite alot when testing this lol.

I enabled the other cache thing too, I had to lower the shadows to "medium" because with DXVK you need to leave some room...

EDIT: Nevermind, I'd gladly see this fixed somehow, as the shadow spot precache tanks the FPS by a lot.

Blisto91 commented 2 years ago

Yes i have reproduced this issue on my R9 380. Tho it is a bit annoying since it also has a tendency to hang my GPU so had to force reboot quite a few times. I don't have any technical knowledge to begin digging deeper into it but I've tried various config options and old versions without luck so far. Will also try to check it out on the Nvidia setup or Steam Deck.

gabriele2000 commented 1 year ago

@K0bin I've managed to trace more glitches, while trying to replay the trace I noticed strange stuff:

I'm uploading the trace now, meanwhile, could you please explain this to me?

EDIT: I forgot to mention that the latest nvidia driver (525.85.05) has corrected just one "terrain glitch", the one that I was showing in the video on the first comment.

https://mega.nz/file/Q8MmUAzT#zwXUJHzkko1RRhz62O1Vm1Un0vgPB10DqiGd0m413hA

Blisto91 commented 1 year ago

Your trace crashes on replay but i managed to get one myself after playing at 0.4fps for half an hour. Sadly it doesn't reproduce with it. Renderdoc also makes the game crash on start. Only clue i've found is that it seems to be a old regression in https://github.com/doitsujin/dxvk/commit/8b5db80fbd3151084e5efbf32933cae13d5e399d

gabriele2000 commented 1 year ago

How did you get this info?

On Sat, 11 Feb 2023, 18:21 Blisto91, @.***> wrote:

Your trace crashes on replay but i managed to get one myself after playing at 0.4fps for half an hour. Sadly it doesn't reproduce with it. Renderdoc also makes the game crash on start. Only clue i've found is that it seems to be a old regression in 8b5db80 https://github.com/doitsujin/dxvk/commit/8b5db80fbd3151084e5efbf32933cae13d5e399d

— Reply to this email directly, view it on GitHub https://github.com/doitsujin/dxvk/issues/3073#issuecomment-1426830626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC47ERND3FWQBEEYAPHEG4DWW7DAXANCNFSM6AAAAAASCOLYDY . You are receiving this because you authored the thread.Message ID: @.***>

Blisto91 commented 1 year ago

Slow and painful testing (mostly because it has a tendency to hang my GPU)

gabriele2000 commented 1 year ago

Yeah but did you inspect the trace to find it?

On Sat, 11 Feb 2023, 19:17 Blisto91, @.***> wrote:

Slow and painful testing (mostly because it has a tendency to hang my GPU)

— Reply to this email directly, view it on GitHub https://github.com/doitsujin/dxvk/issues/3073#issuecomment-1426843955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC47ERKXPO4VKA6J2EOAOATWW7JU5ANCNFSM6AAAAAASCOLYDY . You are receiving this because you authored the thread.Message ID: @.***>

Blisto91 commented 1 year ago

No i tested ingame.

gabriele2000 commented 1 year ago

Slow and painful testing (mostly because it has a tendency to hang my GPU)

You know what's really sad? The only two games that gives me real problems are almost impossible to debug, can't trace them, can't view what's been traced because "yes"...

Heh, nice find by the way! @doitsujin it is possible to try to revert that commit for testing if it solves the problem with those weird two remaster? I hope there's a switch or something in dxvk.conf though.

Blisto91 commented 1 year ago

@doitsujin it is possible to try to revert that commit for testing if it solves the problem with those weird two remaster? I hope there's a switch or something in dxvk.conf though.

Sadly not possible as we don't know what the issue is yet. The commit isn't small and touch alot of d3d11 (also it's ancient)

gabriele2000 commented 1 year ago

Only clue i've found is that it seems to be a old regression in 8b5db80

How did you narrow the issue down to, possibly, this commit?

Blisto91 commented 1 year ago

By gong back to very old versions and noticing it wasn't a issue there. And then afterwards bisect the specific commit it appeared

Blisto91 commented 1 month ago

@gabriele2000 Are you able to verify that this works with dxvk master?

gabriele2000 commented 1 month ago

@gabriele2000 Are you able to verify that this works with dxvk master?

Once I'll reinstall the two games, I'll let you know. It won't be long until I do, maybe less than one month.