doitsujin / dxvk

Vulkan-based implementation of D3D8, 9, 10 and 11 for Linux / Wine
zlib License
13.44k stars 868 forks source link

[util] Unify Borderlands games fixes #4486

Closed Tiagoquix closed 6 days ago

Tiagoquix commented 1 week ago

This PR unifies utility fixes for Borderlands, Borderlands 2 and Borderlands: The Pre-Sequel.

Motives:

These changes were not tested. However, I think they won't cause problems (if there are any).

Thanks to fuzzyquils and pixelcluster for helping me to craft the necessary RegEx on Discord.

doitsujin commented 6 days ago

I don't think all these games being from Gearbox is a good reason to enable more workarounds for the original game? Do we have proof that they are needed?

WinterSnowfall commented 6 days ago

These changes were not tested.

Do try to test these things, since merging untested stuff is generally not a good idea. We sometimes get regressions even with tried and tested changes.

However, I think they won't cause problems (if there are any).

Do they help in any way though? Having a more compact config entry isn't a goal in itself.

Tiagoquix commented 6 days ago

Fair point then. I cannot test all the fixes because I do not own the first game. I'll make a separate PR to address a different issue regarding those fixes.