search

doitsujin / dxvk

Vulkan-based implementation of D3D8, 9, 10 and 11 for Linux / Wine
zlib License
12.84k stars 827 forks source link

Device filter substring matching not working #963

Closed win8linux closed 5 years ago

win8linux commented 5 years ago

Software information

Name of the game, settings used etc.

System information

It seems that substring matching for the device filter setting does not work. Testing with both Metal Gear Solid V: The Phantom Pain and Sleeping Dogs: Definitive Edition, using DXVK_FILTER_DEVICE_NAME="POLARIS11" causes DXVK to fail finding the dGPU:

warn:  DXVK: No adapters found. Please check your device filter settings and Vulkan setup.

Using the dGPU's full device name with DXVK_FILTER_DEVICE_NAME="AMD RADV POLARIS11 (LLVM 7.0.0)", DXVK successfully finds it and uses it.

While this is not yet working, perhaps the README should be updated to reflect this? I've already made the necessary changes here: https://github.com/win8linux/dxvk/commit/afe9dbceade57622d27cfb00aa5991bae000a3b3

Should I make a PR request for this?

EDIT: Oops, made a mistake with one of the env variables.

doitsujin commented 5 years ago

Should I make a PR request for this?

No, because changing the README as a "solution" is exceptionally stupid. You can however submit a PR to fix the bug.

That said, I cannot reproduce this, the device filter works fine for me. Please make sure that you actually use DXVK 1.0 and not an older version.

doitsujin commented 5 years ago

Also, what is DXVK_FAMILY_NAME supposed to be? That environment variable doesn't even exist.

win8linux commented 5 years ago

Oops, I made a mistake there. Changed it to reflect the actual env variable.

win8linux commented 5 years ago

Also, I'm certain that DXVK 1.0 is used since that's the version selected in the Lutris runner options: image

doitsujin commented 5 years ago

Anyway, can you please attach log files?

On my system this clearly works, and since this is a standard library function there's basically no way it wouldn't work for you.

win8linux commented 5 years ago

dxgi.log

The d3d11.log file was empty.

doitsujin commented 5 years ago

Can you also post the log without that env var set?

Joshua-Ashton commented 5 years ago

I too cannot replicate this. Substring matching works fine here and I cannot see a reason in the code for the issues you are having.