Closed abergeron closed 4 years ago
I think I may have misunderstood a thing: I don't think extra dependencies were managed at all on previous versions, but you say that before this, optional dependencies would always be included...
Are we talking about the same extras? https://python-poetry.org/docs/pyproject/#extras
Yes I am talking about those extras. And no poetry2conda didn't manage those before.
The behaviour change is that optional dependencies (marked like this: { version = "1.0", optional = true }
in the regular section) would always get included before and now they aren't.
Oh I see! Well the reason that optional dependencies were included was because I did not even know that poetry feature. If this PR fixes it, that's great!
Excellent!
Monday is a holiday where I live so I will release a new version then, after addressing the two pending issues.
Sorry there is a problem in the test due to the other PR. I'll have a fix in a couple of minutes
Ah and I negligently merged : facepalm:
On Sat, May 30, 2020, 22:26 abergeron notifications@github.com wrote:
Sorry there is a problem in the test due to the other PR. I'll have a fix in a couple of minutes
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dojeda/poetry2conda/pull/5#issuecomment-636380931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCJKTMW6ZND7GKF6SLM4LRUFTYPANCNFSM4NKQFFWQ .
I can make a new PR for the fixes, It's just updating the extras test.
It's fixed in #7
This introduces a behaviour change with regards to previous versions. Before this optional dependencies would always be included since poetry2conda never read the optional flag. Now they are skipped by default.
I do think the change is worth it, but I wanted to point it out.
I've also ran black on the code and included the changes it did.