search

dojo-sim / Dojo.jl

A differentiable physics engine for robotics
MIT License
294 stars 25 forks source link

cartpole_min broken #34

Closed GlenHenshaw closed 1 year ago

GlenHenshaw commented 2 years ago

cartpole_max works, encouragingly. But cartpole_min gives:

    julia> include("cartpole_min.jl")
      Activating project at `~/.julia/packages/Dojo/6iIp0/examples`
    ┌ Info: MeshCat server started. You can open the visualizer by visiting the following URL in your browser:
    └ http://127.0.0.1:8715
    ERROR: LoadError: UndefVarError: cartpole_nominal_max not defined
    Stacktrace:
     [1] top-level scope
       @ ~/.julia/packages/Dojo/6iIp0/examples/trajectory_optimization/cartpole_min.jl:29
     [2] include(fname::String)
       @ Base.MainInclude ./client.jl:451
     [3] top-level scope
       @ REPL[5]:1
    in expression starting at /Users/glenhenshaw/.julia/packages/Dojo/6iIp0/examples/trajectory_optimization/cartpole_min.jl:29
thowell commented 2 years ago

The call to this method should have been Dojo.cartpole_nominal_max. Current main should work now. Thanks!

janbruedigam commented 1 year ago

The cartpole examples were updated. There is a minimal-coordinate cartpole example with LQR now, and an example interfacing ReinforcementLearning.jl with DQN. The RL example might be broken though, since ReinforcementLearningL.jl is going through major changes.